Repository navigation
Load the API user after sign-in so an admin is recognised at once - #2260
Merged
Merged
Conversation
Sign-in endpoints answer with the auth library's user, which keeps the admin flag under attrs. The widget therefore treated an admin as a regular user until the next page load. The countdown on an admin's freshly posted comment came from that. Anonymous, email and Telegram sign-in now fetch /user after the endpoint succeeds. Fixes umputun#2205
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2260 +/- ##
==========================================
+ Coverage 75.00% 75.19% +0.18%
==========================================
Files 129 129
Lines 3757 3761 +4
Branches 869 833 -36
==========================================
+ Hits 2818 2828 +10
+ Misses 933 927 -6
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paskal
previously approved these changes
Oct 11, 2026
# Conflicts: # frontend/apps/remark42/app/components/auth/auth.api.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2205
Sign-in endpoints answer with the auth library's user, which keeps the admin flag under
attrs. The widget stored that user as-is, so it treated an admin as a regular user until the next page load. The edit countdown on an admin's freshly posted comment came from that./useronce the endpoint succeeds and return that user. The fetch skips the/auth/statusprobe thatgetUsermakes first, because that probe tells nothing new right after a successful sign-in.getUserafter the popup closes.